Changeset 35b698 for src/config.cpp

Timestamp:

Jun 23, 2010, 3:52:50 PM (16 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, Candidate_v1.7.0, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

d0fbec

Parents:

dc0d21

git-author:

Frederik Heber <heber@…> (06/23/10 15:20:35)

git-committer:

Frederik Heber <heber@…> (06/23/10 15:52:50)

Message:

BIG CHANGE: config::load and config::save in ParseCommandLineOptions() and main() replaced with FormatParser replacements.

Fragmentation:

• FragmentMolecule() - configuration is not needed anymore, but a path (including prefix)
• class molecule:
  • lots of changes from char * to std:string (due to above): LinearInterpolationBetweenConfiguration(), CheckOrderAtSite(), StoreBondsToFile(), StoreAdjacencyToFile(), CheckAdjacencyFileAgainstMolecule(), CheckAdjacencyFileAgainstMolecule_Init(), ParseOrderAtSiteFromFile(), StoreOrderAtSiteFile(), StoreForcesFile(), ScanAdaptiveFileIntoMap(), StoreForcesFile(), AddHydrogenCorrection(), OutputConfigForListOfFragments()
  • in all above functions, also stringstreams have been replaced by simple strings and file != NULL by file.good()
  • no more CalculateOrbitals(), shifted to class PcpParser
• FragmentationAction: argument of -f is now the prefix, molecule is obtained by molecule-by-id
• no more strcpy needed in: MoleculeLinearInterpolationofTrajectoriesAction, MoleculeSaveAdjacencyAction, MoleculeSaveBondsAction
• oldmenu::FragmentAtoms() - needs to ask for path with prefix now
• config: RetrieveConfigPathAndName() and configpath removed (replaced by above path with prefix)
• changes due to this removal: SaveConfig(), config::Load(), config::LoadOld()

• FIX: MoleculeFillWithMoleculeAction: filler atoms have to be removed before the system can be stored to file.
• FIX: PcpParser::load() - has to put the molecule also into World's MoleculeListClass (otherwise the name cannot be set right after loading)

• ParseCommandLineOptions()
  • new parameter BondGraphFileName and creation of bond graph is done in main()
  • no more config::load, just parser->load(), ConfigFileName is set extra and we always set configPresent to present.
  • FIX: filename is only set when no molecule was allocated before
  • FIX: case 't' and 'f' had wrong argc checks
• main()
  • FormatParserStorage is set with mpqc, pcp and xyz
  • BondGraph is constructed from new string BondGrapghFileName

• new Libparser.a
• all sources from PARSER subdir are compiled into libparser such that only ParserUnitTest is recompiled.

Testfixes:

• testsuite-fragmentation - changes to due to different -f calling syntax.
• most of the xyz files had to be replaced due to a single whitespace at the end of each entry: Domain/6, Simple_configuration/2, Simple_configuration/3, Simple_configuration/4, Simple_configuration/5, Simple_configuration/8
• in many cases were the number orbitals (and thus MaxMinStopStep) wrong: Filling/1, Simple_configuration/4, Simple_configuration/5

Signed-off-by: Frederik Heber <heber@…>

File:

• src/config.cpp (modified) (11 diffs)

src/config.cpp

@@ -31 +31 @@
 /** Constructor for config file class.
  */
-config::config() : BG(NULL), Thermostats(0), PsiType(0), MaxPsiDouble(0), PsiMaxNoUp(0), PsiMaxNoDown(0), MaxMinStopStep(1), InitMaxMinStopStep(1), ProcPEGamma(8), ProcPEPsi(1), configpath(NULL),
+config::config() : BG(NULL), Thermostats(0), PsiType(0), MaxPsiDouble(0), PsiMaxNoUp(0), PsiMaxNoDown(0), MaxMinStopStep(1), InitMaxMinStopStep(1), ProcPEGamma(8), ProcPEPsi(1),
     configname(NULL), FastParsing(false), Deltat(0.01), basis(""), databasepath(NULL), DoConstrainedMD(0), MaxOuterStep(0), mainname(NULL), defaultpath(NULL), pseudopotpath(NULL),
     DoOutVis(0), DoOutMes(1), DoOutNICS(0), DoOutOrbitals(0), DoOutCurrent(0), DoFullCurrent(0), DoPerturbation(0), DoWannier(0), CommonWannier(0), SawtoothStart(0.01),
@@ -42 +42 @@
   pseudopotpath = new char[MAXSTRINGSIZE];
   databasepath = new char[MAXSTRINGSIZE];
-  configpath = new char[MAXSTRINGSIZE];
   configname = new char[MAXSTRINGSIZE];
   Thermostats = new ThermoStatContainer();
@@ -48 +47 @@
   strcpy(defaultpath,"not specified");
   strcpy(pseudopotpath,"not specified");
-  configpath[0]='\0';
   configname[0]='\0';
   basis = "3-21G";
@@ -61 +59 @@
   delete[](pseudopotpath);
   delete[](databasepath);
-  delete[](configpath);
   delete[](configname);
   if (Thermostats != NULL)
@@ -383 +380 @@
 };
 
-/** Retrieves the path in the given config file name.
- * \param filename config file string
- */
-void config::RetrieveConfigPathAndName(const string filename)
-{
-  char *ptr = NULL;
-  char *buffer = new char[MAXSTRINGSIZE];
-  strncpy(buffer, filename.c_str(), MAXSTRINGSIZE);
-  int last = -1;
-  for(last=MAXSTRINGSIZE;last--;) {
-    if (buffer[last] == '/')
-      break;
-  }
-  if (last == -1) { // no path in front, set to local directory.
-    strcpy(configpath, "./");
-    ptr = buffer;
-  } else {
-    strncpy(configpath, buffer, last+1);
-    ptr = &buffer[last+1];
-    if (last < 254)
-      configpath[last+1]='\0';
-  }
-  strcpy(configname, ptr);
-  DoLog(0) && (Log() << Verbose(0) << "Found configpath: " << configpath << ", dir slash was found at " << last << ", config name is " << configname << "." << endl);
-  delete[](buffer);
-};
-
 /** Loads a molecule from a ConfigFileBuffer.
  * \param *mol molecule to load
@@ -603 +573 @@
   file->close();
   delete(file);
-  RetrieveConfigPathAndName(filename);
 
   // ParseParameterFile
@@ -840 +809 @@
     return;
   }
-  RetrieveConfigPathAndName(filename);
   // ParseParameters
 
@@ -1525 +1493 @@
   molecule *mol = NULL;
 
-  if (!strcmp(configpath, GetDefaultPath())) {
-    eLog() << Verbose(2) << "config is found under different path then stated in config file::defaultpath!" << endl;
-  }
-
-
   // first save as PDB data
   if (ConfigFileName != NULL)
@@ -1566 +1529 @@
     mol->doCountAtoms();
     mol->CountElements();
-    mol->CalculateOrbitals(*this);
+    //mol->CalculateOrbitals(*this);
     delete[](src);
   } else {
@@ -1572 +1535 @@
       mol = *(molecules->ListOfMolecules.begin());
       mol->doCountAtoms();
-      mol->CalculateOrbitals(*this);
+      //mol->CalculateOrbitals(*this);
     } else {
       DoeLog(1) && (eLog() << Verbose(1) << "There are no molecules to save!" << endl);
@@ -1634 +1597 @@
   else
     Log() << Verbose(0) << "\t... failed." << endl;
-
-  if (!strcmp(configpath, GetDefaultPath())) {
-    eLog() << Verbose(2) << "config is found under different path then stated in config file::defaultpath!" << endl;
-  }
 
   // don't destroy molecule as it contains all our atoms