Changeset c742bb1

Timestamp:

Dec 26, 2025, 9:40:14 PM (22 hours ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Candidate_v1.7.1, stable

Children:

56496c

Parents:

033646

git-author:

Frederik Heber <frederik.heber@…> (12/19/25 21:06:48)

git-committer:

Frederik Heber <frederik.heber@…> (12/26/25 21:40:14)

Message:

Removes some Observer::signOn's from GLWorldView.

• since the QtInstanceBoard addition we had no longer needed to sign onto changes from AtomObserver.
• since the recent QtTimeline change, we also don't need the WorldTime signing.
• only the ShapeRegistry remains.

Location:

src/UIElements/Views/Qt4/Qt3D

Files:

• GLWorldView.cpp (modified) (4 diffs)
• GLWorldView.hpp (modified) (1 diff)

src/UIElements/Views/Qt4/Qt3D/GLWorldView.cpp

@@ -71 +71 @@
   Observer("GLWorldView"),
   worldscene(NULL),
-  changesPresent(false)
+  changesPresent(false),
+  needsRedraw(false)
 {
   worldscene = new GLWorldScene(_board, this);
@@ -99 +100 @@
       worldscene, SLOT(moleculesVisibilityChanged(ObservedValue_Index_t,bool)));
 
-  // sign on to changes in the world
-  WorldTime::getInstance().signOn(this, WorldTime::TimeChanged);
-  AtomObserver::getInstance().signOn(this, AtomObservable::PositionChanged);
-  AtomObserver::getInstance().signOn(this, AtomObservable::VelocityChanged);
-  AtomObserver::getInstance().signOn(this, AtomObservable::ForceChanged);
-
+  // sign on to changes in the shape registry
   ShapeRegistry::getInstance().signOn(this);
   ShapeRegistry::getInstance().signOn(this, ShapeRegistry::ShapeInserted);
@@ -122 +118 @@
 
 
-  WorldTime::getInstance().signOff(this, WorldTime::TimeChanged);
-  AtomObserver::getInstance().signOff(this, AtomObservable::PositionChanged);
-  AtomObserver::getInstance().signOff(this, AtomObservable::VelocityChanged);
-  AtomObserver::getInstance().signOff(this, AtomObservable::ForceChanged);
   ShapeRegistry::getInstance().signOff(this);
   ShapeRegistry::getInstance().signOff(this, ShapeRegistry::ShapeInserted);
@@ -340 +332 @@
 void GLWorldView::recieveNotification(Observable *publisher, Notification_ptr notification)
 {
-  if (static_cast<WorldTime *>(publisher) == WorldTime::getPointer()) {
-    switch (notification->getChannelNo()) {
-      case WorldTime::TimeChanged:
-      {
-#ifdef LOG_OBSERVER
-      observerLog().addMessage() << "++ Observer " << observerLog().getName(static_cast<Observer *>(this)) << " received notification that WorldTime's time has changed.";
-#endif
-        emit updated(false);
-        emit TimeChanged();
-        break;
-      }
-      default:
-        ASSERT(0, "GLWorldView::recieveNotification() - we cannot get here for WorldTime.");
-        break;
-    }
-  } else if (static_cast<ShapeRegistry*>(publisher) == ShapeRegistry::getPointer()) {
+  if (static_cast<ShapeRegistry*>(publisher) == ShapeRegistry::getPointer()) {
     switch (notification->getChannelNo()) {
       case ShapeRegistry::ShapeInserted:

src/UIElements/Views/Qt4/Qt3D/GLWorldView.hpp

@@ -69 +69 @@
   void updated(const bool _needsRedraw);
   void sceneUpdated();
-  void TimeChanged();
   void worldSelectionChanged();
   void hoverChanged(const atomId_t _id);